[PATCH] D29564: [DAGCombiner] (add X, (adde Y, 0, Carry)) -> (adde X, Y, Carry)

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: test/CodeGen/X86/adde-carry.ll:89
 
 define %scalar @pr31719(%scalar* nocapture readonly %this, %scalar %arg.b) {
 ; CHECK-LABEL: pr31719:
----------------
zvi wrote:
> If you intend to improve this test case in future patches, i think you should add a dedicated minimal test to ensure the combine introduced this patch will be covered. Other than that LGTM 
I don't think that's a problem. The add case is always the bottom turtle.


https://reviews.llvm.org/D29564