[PATCH] D29504: Merge DebugLoc on combined stores

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: test/DebugInfo/Generic/store-tail-merge.ll:5
+;
+; clang -S -g -emit-llvm test.c -o 1.ll
+; opt -sroa -S 1.ll -o test.ll
----------------
This test only requires `-gline-tables-only`. You don't need any @llvm.dbg.value calls and/or extra metadata for debug info types and variables.


================
Comment at: test/DebugInfo/Generic/store-tail-merge.ll:69
+!llvm.module.flags = !{!3, !4, !5}
+!llvm.ident = !{!6}
+
----------------
This entry is not needed. You can get rid of !6. also replace the producer string with an empty string.


https://reviews.llvm.org/D29504