[PATCH] D29391: [ELF] - Postpone the evaluation of DefinedSynthetic value

[George Rimar via llvm-commits]

>>We should *NOT* do this. If the symbol is created too early we should
>>delay the symbol creation, not turn Value into a callback.
>>
>>Please include a new minimal testcase of what is being fixed in the
>>patch.
>>
>>Cheers,
>>Rafael
>
>We create all symbols early, in:
>Script<ELFT>::X->processCommands(Factory);
>...
>template <class ELFT> static void addSymbol(SymbolAssignment *Cmd)
>
>If we do not do that, I think we can end up with undefined symbol error, don't we ?
>
>I'll update the patch with separate testcase.
>(before that I extended non-absolute.s to show what was fixed, I'll separate it then).
>
>George.

So I think we probably can delay the *assign* of values for this symbols instead of turning Value
into callback, but it doesn't looks like we can delay *creation*.
What do you think ?

George.