[PATCH] D26855: New unsafe-fp-math implementation for X86 target

[Guy Blank via Phabricator via llvm-commits]

guyblank added a comment.

In https://reviews.llvm.org/D26855#667256, @RKSimon wrote:

> In https://reviews.llvm.org/D26855#667181, @guyblank wrote:
>
> > But I'm also concerned about other cpus for which we don't have an accurate scheduler model (broadwell, skylake), should these be excluded as well?
>
>
> If the cpu is using an older scheduler model then its already not necessarily being optimally scheduled - I don't see this patch being any different.


Currently the older schedule "only" affects the schedule, but with this patch (and future ones using the machine combiner framework) it will affect which instructions we emit. This could possibly lead to generating worse code than we do at the moment.


https://reviews.llvm.org/D26855