[lld] r293792 - Strip file path from the -o option while creating reproduce.txt.

[Sean Silva via llvm-commits]

On Fri, Feb 3, 2017 at 11:39 AM, Ed Maste via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On 1 February 2017 at 18:52, Rafael Avila de Espindola
> <rafael.espindola at gmail.com> wrote:
> >
> > Can you expand a bit on the use case of preserving the full path?
>
> During some FreeBSD experiments I built with make -i (ignore
> failures), then set the reproduce environment variable and reran with
> make -i. That gave me a reproduction .tar and response file for each
> failing case, which I reran with ld.bfd to produce the output directly
> in the target directory. This was mainly a convenience because the
> FreeBSD build builds its own toolchain so it's not necessarily
> straightforward to find the exact invocation used, or rebuild one
> component with special CFLAGS etc. All of that said, for FreeBSD we're
> beyond the point where this is needed now and I don't have a strong
> feeling on it.
>

While FreeBSD may be beyond the point of needing this, the experiences with
FreeBSD can inform our behavior so that things are easy for future
platforms. FreeBSD is hopefully not the last platform to adopt LLD as the
system linker :)

If I understand this correctly, the main issue with this patch is that the
repro archive no longer contains information about the absolute path of the
output file of the original invocation. That seems useful to preserve (and
it seems based on Rui's patch that it's possible to do quite easily). I
remember we thought about (and maybe did?) do something like you did during
the bringup of LLD for the PS4 base system.

-- Sean Silva


> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170203/357c244e/attachment.html>