[PATCH] D29519: Add PredicateInfo utility and printing pass

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 16:45:28 PST 2017


Prazek added inline comments.


================
Comment at: lib/Transforms/Utils/PredicateInfo.cpp:433
+void PredicateInfo::renameUses(SmallPtrSetImpl<Value *> &OpsToRename) {
+  ValueDFS_Compare A(OBBMap);
+  // Compute liveness, and rename in O(uses) per Op.
----------------
This looks like a single usage of the OBBMap inside PredicateInfo.
Shouldn't it be just created inside ValueDFS_Compare?



https://reviews.llvm.org/D29519





More information about the llvm-commits mailing list