[PATCH] D29481: [Support] Add FormatVariadic support for chrono types
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 14:24:18 PST 2017
labath marked 2 inline comments as done.
labath added inline comments.
================
Comment at: include/llvm/Support/Chrono.h:70
+/// | "ms-" | 1s | 1000 |
+/// | "ms-n" | 1s | 1,000 ms |
+/// | "" | 1.0s | 1.00 s |
----------------
zturner wrote:
> Shouldn't the output here be `1,000`? The presence of `-` suggests that the unit should not be displayed.
Indeed it should. Thanks for catching this.
https://reviews.llvm.org/D29481
More information about the llvm-commits
mailing list