[PATCH] D29500: [DWARF][PATCH] Keep track of spilled variables in LiveDebugValues

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 14:08:21 PST 2017


wolfgangp added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:176
   typedef SmallDenseMap<const MachineBasicBlock *, VarLocSet> VarLocInMBB;
+  typedef std::pair<MachineInstr *, MachineInstr *> MIPair;
+  typedef SmallVector<MIPair, 4> SpillMap;
----------------
aprantl wrote:
> Does the code get more readable by making this a struct with named fields instead?
Yes, I should think so. I'll do that.


https://reviews.llvm.org/D29500





More information about the llvm-commits mailing list