[PATCH] D29324: [ELF] - Allow to combine sections of type SHT_NOTE with different attributes.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 11:19:29 PST 2017
Evgeny Leviant <eleviant at accesssoftek.com> writes:
> Like George and Dave, I also think that having some way to bypass these flag/type checks is not a bad idea. For instance I had to patch some our assembly files, because code sections missed "ax" attributes.?
>
> If we already can merge nobits and progbits sections, why can't we do
> the same with alloc / non-alloc sections then? May be emit warning
> instead of error in such cases?
I really think there is no point in making this an option. If someone
has to modify their makefile to add a lld only option they may as well
add the missing "a" to the assembly.
If this is fairly common or if there is a good justification as to why
it is useful (as with NOBITS), then we should just implement
it. Otherwise we should keep producing errors,
Cheers,
Rafael
More information about the llvm-commits
mailing list