[PATCH] D29404: [ValueTracking] emit a warning when we detect a conflicting assumption (PR31809)

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.

This LGTM now both in terms of the usage of ORE and the nature of the diagnostic. It would be good to have someone else also sign off on the choice of the diagnostics though.



================
Comment at: lib/Analysis/ValueTracking.cpp:80
   const DominatorTree *DT;
+  OptimizationRemarkEmitter *ORE;
 
----------------
Say that this could really be null (unlike other analyses) because not all clients provide it currently.


https://reviews.llvm.org/D29404