[PATCH] D29445: LTO: add a code-model flag
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 08:08:52 PST 2017
> + if (auto *Arg = Args.getLastArg(OPT_code_model_eq)) {
> + StringRef S = Arg->getValue();
> + if (S == "default") {
> + Config->CModel = CodeModel::Default;
> + } else if (S == "small") {
> + Config->CModel = CodeModel::Small;
> + } else if (S == "kernel") {
> + Config->CModel = CodeModel::Kernel;
> + } else if (S == "medium") {
> + Config->CModel = CodeModel::Medium;
> + } else if (S == "large") {
> + Config->CModel = CodeModel::Large;
> + } else {
> + error("unknown code model: " + S);
> + }
> + }
Can you use a StringSwitch? Even if you don't, you can drop the {}.
Can you add a test for gold too?
Cheers,
Rafael
More information about the llvm-commits
mailing list