[PATCH] D29168: [compiler-rt] Use interception to access to strong functions defined in the main executable.

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 14:34:12 PST 2017


alekseyshl accepted this revision.
alekseyshl added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/sanitizer_common/sanitizer_win_weak_interception.cc:33
+  uptr real = __interception::InternalGetProcAddress(
+    (void *)GetModuleHandleA(0), real_function);
+  if (real && !__interception::OverrideFunction((uptr)dll_function, real, 0))
----------------
Four spaces indent.


================
Comment at: lib/sanitizer_common/sanitizer_win_weak_interception.cc:71
+__declspec(allocate(".CRT$XIB")) int (*__weak_intercept_preinit)() =
+  weak_intercept_init;
+
----------------
Four spaces indent.


https://reviews.llvm.org/D29168





More information about the llvm-commits mailing list