[PATCH] D29425: [SLP] Use SCEV to sort memory accesses

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 07:37:43 PST 2017


mssimpso added inline comments.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1093-1095
+              const SCEVConstant *Diff = dyn_cast<SCEVConstant>(
+                  SE.getMinusSCEV(Right.first, Left.first));
+              return (Diff && (Diff->getAPInt().isStrictlyPositive()));
----------------
Do we require constant differences? If not, you could also ask SCEV about the range:

```
return SE.isKnownPositive(SE.getMinusSCEV(Right.first, Left.first))
```


https://reviews.llvm.org/D29425





More information about the llvm-commits mailing list