[PATCH] D20116: Add speculatable function attribute

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM. But let's wait a little to give a change to @sanjoy or @chandlerc to comment if they feel the need.

I repeat here one of the important earlier comment from @tstellarAMD , since it is not in the description and easy to miss:

  I added two new Intrinsic attributes IntrNoSideEffects and IntrHasSideEffects,
  which make it possible to specify all the possible memory interaction / side effect
  combinations. With these properties in place, it should be possible in the future
  to drop the 'no side effect' portion of the intrinsic memory properties once targets
  have been updated to use these new properties.


https://reviews.llvm.org/D20116