[PATCH] D29203: Change debug-info-for-profiling from a TargetOption to a function attribute.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 16:56:30 PST 2017


dlj added inline comments.


================
Comment at: test/DebugInfo/Generic/gmlt.test:2
 ; REQUIRES: object-emission
 ; RUN: %llc_dwarf -O0 -filetype=obj < %S/../Inputs/gmlt.ll | llvm-dwarfdump - | FileCheck %S/../Inputs/gmlt.ll
+; RUN: %llc_dwarf -O0 -filetype=obj < %S/../Inputs/gmlt_profiling.ll | llvm-dwarfdump - | FileCheck %S/../Inputs/gmlt_profiling.ll
----------------
dblaikie wrote:
> This line should probably be in gmlt.ll (both gmlt.ll and gmlt_profiling.ll would move from test/DebugInfo/Inputs to test/DebugInfo/Generic)
Moving this file to Generic/ means that other tests (notably, under X86/) now use  files not within their Inputs, or within their parents' Inputs. Was that the intent of this comment?


https://reviews.llvm.org/D29203





More information about the llvm-commits mailing list