[llvm] r293373 - This addresses LLDB bug 31699, which was caused by LLVM using static linking on Windows.

[Hans Wennborg via llvm-commits]

On Tue, Jan 31, 2017 at 2:44 PM, Vadim Chugunov <vadimcn at gmail.com> wrote:
>>
>> I tried upgrading to CMake 3.7 and re-buliding but that didn't help :-/
>>
>> I think I have the SDK; at least I have a "v10.0A" dir in C:\Program
>> Files (x86)\Microsoft SDKs\Windows.
>
>
> Can you please check whether your SDK has the "Redist\ucrt\DLLs" subfolder?
> (for example, Windows SDK shipped with VS2015 did not have it).  You may
> need to grab latest SDK from here.

It seems I did have the WIn 10 SDK, but not the right version :-/ New
attempt that I believe has the right dlls:
http://llvm.org/pre-releases/win-snapshots/LLVM-5.0.0-r293544-win32.exe

>> Shouldn't cmake error out or something if it can't find the files?
>
>
> Unfortunately it does not.  (If you are using cmake-gui, it'll show the
> redist path variable in red, but this isn't a hard error).

Would you mind filing a bug with the cmake people about this? It seems
really bad that -DCMAKE_INSTALL_UCRT_LIBRARIES=ON can just fail
silently.


>> > On Mon, Jan 30, 2017 at 7:01 PM, Hans Wennborg <hans at chromium.org>
>> > wrote:
>> >>
>> >> I've just built a new snapshot that includes this revision:
>> >> http://llvm.org/pre-releases/win-snapshots/LLVM-4.0.0-r293474-win32.exe
>> >>
>> >> Can you please verify that it works and includes the correct DLLs? And
>> >> does it help LLDB?
>> >>
>> >> When I install it, I see these in the bin\ directory:
>> >> msvcp140.dll
>> >> vcruntime140.dll
>> >>
>> >> Thanks for pushing this forward!
>> >>
>> >> Hans
>> >>
>> >>
>> >> On Fri, Jan 27, 2017 at 11:39 PM, Vadim Chugunov via llvm-commits
>> >> <llvm-commits at lists.llvm.org> wrote:
>> >> > Author: vadimcn
>> >> > Date: Sat Jan 28 01:39:52 2017
>> >> > New Revision: 293373
>> >> >
>> >> > URL: http://llvm.org/viewvc/llvm-project?rev=293373&view=rev
>> >> > Log:
>> >> > This addresses LLDB bug 31699, which was caused by LLVM using static
>> >> > linking on Windows.
>> >> >
>> >> > In order to make sure that LLVM continues to work on machines that do
>> >> > not have the Universal CRT yet,
>> >> > we'll need to ship a copy of UCRT in the Windows installation
>> >> > package.
>> >> > Fortunately, CMake 3.6+ already
>> >> > supports app-local deployment of UCRT dlls, we just need to turn this
>> >> > on.
>> >> >
>> >> > Differential Revision: https://reviews.llvm.org/D29146
>> >
>> >
>> >
>
>