[PATCH] D29414: [Assembler] Enable nicer diagnostics for inline assembly.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 14:22:34 PST 2017


rengolin added a comment.

This is simple and makes sense. But all the other inline asm look correlated. Since you marked as dependencies, and phab is not really great to handle deps, can I ask you a favour?

Try to join all inline asm reporting dependencies into a new patch (don't mess up the existing ones), just so we see how it looks like.

At least the squashed patch will give us an overview or what they accomplish. It may even make more sense to commit squashed, in case we need to revert one in between, reverting a single patch is easier than 5. :)

cheers,
--renato


https://reviews.llvm.org/D29414





More information about the llvm-commits mailing list