[PATCH] D29423: [AMDGPU] Account workgroup size in LDS occupancy limits

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.cpp:71-74
+  if (LocalMemorySize == 0) {
+    if (getGeneration() == SOUTHERN_ISLANDS) LocalMemorySize = 32768;
+    else if (getGeneration() >= SEA_ISLANDS) LocalMemorySize = 65536;
+  }
----------------
arsenm wrote:
> This should never happen. These values are already defined by the subtarget feature which set these values. Are you seeing this happen? Is the feature missing for some reason from some processor definitions?
Thanks, I have overlooked that.


Repository:
  rL LLVM

https://reviews.llvm.org/D29423