[PATCH] D29362: Return Error instead of bool from mergeTypeStreams().

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 11:40:12 PST 2017


ruiu added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp:176
   TypeVisitorCallbackPipeline Pipeline;
+  LastError = Error::success();
 
----------------
No, because we overwrite it unconditionally here.


https://reviews.llvm.org/D29362





More information about the llvm-commits mailing list