[PATCH] D29363: [XRAY] A Color Choosing helper for XRay Graph

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: tools/llvm-xray/xray-color-helper.cc:524-526
+  for (const auto &c : a) {
+    B = c + B * x_0;
+  }
----------------
usually skip the {} on single line blocks


================
Comment at: tools/llvm-xray/xray-color-helper.h:23
+class ColorHelper{
+ private:
+  ArrayRef<double> RedPoly;
----------------
I think this is probably google style clang-tidy (one space indenting the private/protected/etc) - don't think it's LLVM's style?


https://reviews.llvm.org/D29363