[PATCH] D29392: [ELF] - Change value checks to checkUInt for R_386_8/R_386_PC8/R_386_16/R_386_PC16 relocations.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 09:52:49 PST 2017


ruiu added a comment.

Can you describe why this is correct? Relaxing the error checks until the kernel links is not a good idea.

I believe you should use checkUInt for R_386_{8,16} and checkInt for R_386_PC{8,16}.


https://reviews.llvm.org/D29392





More information about the llvm-commits mailing list