[PATCH] D28489: [CodeGen] Move MacroFusion to the target

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a comment.

Usings of \param are improper. Tweaked in r293744 just to eliminate \param(s).

\param takes at least two parameters.

  \param NAME Description...

You may write \param(s) like,

  /// \brief Verify that the instruction pair, should be scheduled back to back.
  /// \param First The first MI to verify
  /// \param Second The second MI

Note, trunk clang doesn't recognize like "\param First,Second".



================
Comment at: llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp:29
+
+/// \brief Verify that the instruction pair, \param First and \param Second,
+/// should be scheduled back to back.  Given an anchor instruction, if the other
----------------
First and Second


================
Comment at: llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp:123
+/// \brief Implement the fusion of instruction pairs in the scheduling
+/// \param DAG, anchored at the instruction in \param ASU. \param Preds
+/// indicates if its dependencies in \param APreds are predecessors instead of
----------------
DAG, ASU, and Preds


================
Comment at: llvm/trunk/lib/Target/X86/X86MacroFusion.cpp:29
+
+/// \brief Verify that the instruction pair, \param First and \param Second,
+/// should be scheduled back to back.  If either instruction is unspecified,
----------------
First and Second


Repository:
  rL LLVM

https://reviews.llvm.org/D28489