[PATCH] D29371: [libFuzzer] Properly check if we can use dumpbin .

[Zachary Turner via llvm-commits]

Lgtm
On Tue, Jan 31, 2017 at 9:27 PM Marcos Pividori via Phabricator <
reviews at reviews.llvm.org> wrote:

> mpividori created this revision.
>
> The flag "/sumary" is necessary, otherwise it returns a non-zero value.
>
>
> https://reviews.llvm.org/D29371
>
> Files:
>   lib/Fuzzer/FuzzerUtilWindows.cpp
>
>
> Index: lib/Fuzzer/FuzzerUtilWindows.cpp
> ===================================================================
> --- lib/Fuzzer/FuzzerUtilWindows.cpp
> +++ lib/Fuzzer/FuzzerUtilWindows.cpp
> @@ -179,7 +179,7 @@
>  }
>
>  std::string DisassembleCmd(const std::string &FileName) {
> -  if (ExecuteCommand("dumpbin > nul") == 0)
> +  if (ExecuteCommand("dumpbin /summary > nul") == 0)
>      return "dumpbin /disasm " + FileName;
>    if (ExecuteCommand("llvm-objdump > nul") == 0)
>      return "llvm-objdump -d " + FileName;
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170201/716b98ef/attachment.html>