[PATCH] D29364: [ELF] Handle multiple discontiguous .note sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:1236-1240
+    if (Sec->Type == SHT_NOTE) {
+      if (!Load->Last || Load->Last->Type != SHT_NOTE)
+        Notes.emplace_back(PT_NOTE, PF_R);
+      Notes.back().add(Sec);
+    }
----------------
Can you move this code out of this `for` loop and create a new loop only for .notes? I think doing that improves readability.


Repository:
  rL LLVM

https://reviews.llvm.org/D29364