[PATCH] D29354: SanitizerCoverage: Support sanitizer guard section on darwin

[Justin Bogner via Phabricator via llvm-commits]

bogner updated this revision to Diff 86525.
bogner added a comment.

Get rid of the pointless string-abstraction macro. As Kostya and Kuba pointed out, it isn't really doing anything (and it's actually longer than just writing out the string).

Also note we'll need to un-xfail a test in compiler-rt when this is committed:

diff --git a/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cc b/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cc
index 1b787f143..e54993c5a 100644

- a/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cc

+++ b/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cc
@@ -1,7 +1,7 @@
 // Tests trace pc guard coverage collection.
 //
 // REQUIRES: has_sancovcc,stable-runtime
-// XFAIL: tsan,darwin,powerpc64,s390x
+// XFAIL: tsan,powerpc64,s390x
 //
 // RUN: DIR=%t_workdir
 // RUN: rm -rf $DIR


https://reviews.llvm.org/D29354

Files:
  lib/Transforms/Instrumentation/SanitizerCoverage.cpp
  test/Instrumentation/SanitizerCoverage/tracing.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29354.86525.patch
Type: text/x-patch
Size: 5348 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170201/b2e2c086/attachment.bin>