[PATCH] D29345: [sanitizer] Fix test on Darwin failing after 293682

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added a comment.

On macOS, `nm -gm` shows weak symbols:

  $ nm -g $(pwd)/lib/clang/4.0.0/lib/darwin/libclang_rt.asan_osx_dynamic.dylib
  ...
  0000000000077b10 (__TEXT,__text) external ___sanitizer_symbolize_pc
  ...
                   (undefined) weak external ___ubsan_default_options (dynamically looked up)
  ...

Btw, the current status of the patch fails with:

  === NOTE === If you see a mismatch below, please update sanitizer_interface.inc files.
  6a7,8
  > __asan_default_options
  > __asan_default_suppressions
  49a52
  > __asan_on_error
  143a147
  > __sancov_default_options
  151a156,162
  > __sanitizer_cov_trace_cmp
  > __sanitizer_cov_trace_cmp1
  > __sanitizer_cov_trace_cmp2
  > __sanitizer_cov_trace_cmp4
  > __sanitizer_cov_trace_cmp8
  > __sanitizer_cov_trace_div4
  > __sanitizer_cov_trace_div8
  152a164,168
  > __sanitizer_cov_trace_gep
  > __sanitizer_cov_trace_pc_guard
  > __sanitizer_cov_trace_pc_guard_init
  > __sanitizer_cov_trace_pc_indir
  > __sanitizer_cov_trace_switch
  170a187
  > __sanitizer_print_memory_profile
  173a191
  > __sanitizer_report_error_summary
  174a193
  > __sanitizer_sandbox_on_notify
  188a208
  > __ubsan_default_options



================
Comment at: test/asan/TestCases/Darwin/interface_symbols_darwin.c:16
 //
-// RUN: grep -e "INTERFACE_\(WEAK_\)\?FUNCTION"                                \
+// RUN: grep -e "INTERFACE_FUNCTION"                                           \
 // RUN:  %p/../../../../lib/asan/asan_interface.inc                            \
----------------
Sigh.  I hoped we could also check weak exports.


https://reviews.llvm.org/D29345