[PATCH] D29345: [sanitizer] Fix test on Darwin failing after 293682
Marcos Pividori via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 31 13:03:26 PST 2017
mpividori created this revision.
This changes fix the tests for Darwin. I forgot to filter the symbols with "TWw". Also I filter `__sanitizer_mz*`.
If fact it would be better if we could use: `nm -D` instead of `nm -g`. (we do that on linux in `interface_symbol_linux.c` test) Is only outdated or we can not use `-D` on Darwin? Could you check?
Thanks!
https://reviews.llvm.org/D29345
Files:
test/asan/TestCases/Darwin/interface_symbols_darwin.c
Index: test/asan/TestCases/Darwin/interface_symbols_darwin.c
===================================================================
--- test/asan/TestCases/Darwin/interface_symbols_darwin.c
+++ test/asan/TestCases/Darwin/interface_symbols_darwin.c
@@ -5,9 +5,11 @@
// RUN: %clang_asan -dead_strip -O2 %s -o %t.exe
//
// RUN: nm -g `%clang_asan %s -fsanitize=address -### 2>&1 | grep "libclang_rt.asan_osx_dynamic.dylib" | sed -e 's/.*"\(.*libclang_rt.asan_osx_dynamic.dylib\)".*/\1/'` \
+// RUN: | grep " [TWw] " \
// RUN: | grep -o "\(__asan_\|__ubsan_\|__sancov_\|__sanitizer_\)[^ ]*" \
// RUN: | grep -v "__sanitizer_syscall" \
// RUN: | grep -v "__sanitizer_weak_hook" \
+// RUN: | grep -v "__sanitizer_mz" \
// RUN: | sed -e "s/__asan_version_mismatch_check_v[0-9]+/__asan_version_mismatch_check/" \
// RUN: > %t.exports
//
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29345.86482.patch
Type: text/x-patch
Size: 1018 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170131/11cf72e4/attachment.bin>
More information about the llvm-commits
mailing list