[PATCH] D27586: AMDGPU/SI: Add llvm.amdgcn.s.buffer.load intrinsic

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 11:46:35 PST 2017


tstellarAMD added inline comments.


================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:405
+def int_amdgcn_s_buffer_load : Intrinsic <
+  [llvm_anyint_ty],
+  [LLVMQualPointerType<LLVMMatchType<0>, 42>,
----------------
arsenm wrote:
> This should probably be a more general type so that you can also mangle with FP types
The only other option would be llvm_any_ty, I think tablegen needs some more work to make this happen.  But we can always change this in the future without breaking backwards compatibility, because the intrinsic is already overloaded.


https://reviews.llvm.org/D27586





More information about the llvm-commits mailing list