[PATCH] D29341: [scudo] 32-bit quarantine sizes adjustments and bug fixes

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 11:27:14 PST 2017


cryptoad created this revision.

The local and global quarantine sizes were not offering a distinction for
32-bit and 64-bit platforms. This is addressed with lower values for 32-bit.

When writing additional tests for the quarantine, it was discovered that when
calling some of the allocator interface function prior to any allocation
operation having occured, the test would crash due to the allocator not being
initialized. This was addressed by making sure the allocator is initialized
for those scenarios.

Relevant tests were added in interface.cpp and quarantine.cpp.

Last change being the removal of the extraneous link dependencies for the
tests thanks to https://reviews.llvm.org/rL293220, anf the addition of the gc-sections linker flag.


https://reviews.llvm.org/D29341

Files:
  lib/scudo/scudo_allocator.cpp
  lib/scudo/scudo_flags.cpp
  lib/scudo/scudo_flags.inc
  test/scudo/interface.cpp
  test/scudo/lit.cfg
  test/scudo/quarantine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29341.86469.patch
Type: text/x-patch
Size: 8842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170131/4e1eeede/attachment.bin>


More information about the llvm-commits mailing list