[PATCH] D29315: MCMacho: Allow __thread_ptr section after dwarf sections

Jim Grosbach via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 10:33:58 PST 2017


grosbach added inline comments.


================
Comment at: test/MC/MachO/ARM/no-tls-assert.ll:2
+; RUN: llc -filetype=obj -o /dev/null %s
+; This should not trigger the "Creating regular section after DWARF" assert.
+target triple = "thumbv7-apple-ios9.0.0"
----------------
MatzeB wrote:
> aprantl wrote:
> > It would be better to check the ASM output for the section switch commands. Otherwise this test succeeds even if llc is symlinked to /bin/true ;-)
> The assert would not trigger when writing assembly, but I can probably pipe the output through llvm-objdump.
That's concerning. What is the assembler doing differently? Any output from the object emitter directly from the compiler should be reproducible when going through assembly.


Repository:
  rL LLVM

https://reviews.llvm.org/D29315





More information about the llvm-commits mailing list