[PATCH] D29324: [ELF] - Allow to combine sections of type SHT_NOTE with different attributes.

Dave Bozier via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 09:01:48 PST 2017


> By the way, may be we want to implement some simple option like -z
permissive-flags

I think that's not a bad idea. Inconsistent type/flags is not an uncommon
scenario. Ben has already mentioned the same for section types here
https://reviews.llvm.org/D29278. We've seen a number of codebases where
developers will write assembly but forget to correctly configure type/flags
to a section, in some cases where the developer are unable/unwilling to
change their source.

maybe permissive-section-flags to be more explicit. Maybe worth also adding
permissive-section-type too?

On Tue, Jan 31, 2017 at 4:49 PM, George Rimar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> >So, this really looks like a bug in the kernel. Even some of its flags
> >are marked alloc.
> >
> >Can you try changing include/linux/elfnote.h to have
> >
> >#define ELFNOTE(name, type, desc)               \
> >        ELFNOTE_START(name, type, "a")          \
> >                desc                    ;       \
> >        ELFNOTE_END
> >
> >and see if that fixes the problem?
> >
>
> Sure, I'll check that tomorrow and return with info.
>
> By the way, may be we want to implement some simple option like -z
> permissive-flags, which
> will ignore flags checks ? It looks it can be not a unique case for
> software that have such issues.
>
> George.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170131/3e27f265/attachment.html>


More information about the llvm-commits mailing list