[PATCH] D29321: [globalisel] Make the MatchAction hierarchy consistent with the matchers. NFC.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:330
+    Actions.emplace_back(llvm::make_unique<Kind>(std::forward<Args>(args)...));
+    return *Actions.back();
+  }
----------------
kristof.beyls wrote:
> The corresponding function addPredicate(Args&&... args) has the same implementation, except for this return statement:
>     return *static_cast<Kind *>(Predicates.back().get());
> 
> Any reason why it needs to be different?
Thanks for noticing. There's no reason behind it, it's just a silly mistake on my part. I've updated the patch


https://reviews.llvm.org/D29321