[PATCH] D29282: [ELF] - Report filename for unknown relocation error.

bd1976 llvm via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 01:58:40 PST 2017


Great, LGTM,

On Tue, Jan 31, 2017 at 9:13 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> > What would the output look like if the elf was in an archive?
>
> According to toString() code:
>
> // Returns "(internal)", "foo.a(bar.o)" or "baz.o".
> std::string lld::toString(const InputFile *F) {
>   if (!F)
>     return "(internal)";
>   if (!F->ArchiveName.empty())
>     return (F->ArchiveName + "(" + F->getName() + ")").str();
>   return F->getName();
> }
>
> It should be:
> foo.a(bar.o): unknown relocation type: Unknown (152)
>
> George.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170131/ad0d8e3e/attachment.html>


More information about the llvm-commits mailing list