[PATCH] D28508: [NVPTX] Implement NVPTXTargetLowering::getSqrtEstimate.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 23:45:39 PST 2017


jlebar added a comment.

Looking through this code, we don't even parse the mrecip string properly.  For example, `all,!sqrt` should enable reciprocal approximations for everything other than sqrt, but as I read TargetLoweringBase::getOpEnabled, it enables it for nothing.  :(


Repository:
  rL LLVM

https://reviews.llvm.org/D28508





More information about the llvm-commits mailing list