[PATCH] D28750: [lld] [cmake] Support running tests in stand-alone builds

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

LG beyond the few nits.



================
Comment at: CMakeLists.txt:67
+
+    if( ${PYTHON_VERSION_STRING} VERSION_LESS 2.7 )
+      message(FATAL_ERROR "Python 2.7 or newer is required")
----------------
No spaces around the condition.


================
Comment at: CMakeLists.txt:110
+      # On Win32 hosts, provide an option to specify the path to the GnuWin32 tools.
+      if( WIN32 AND NOT CYGWIN )
+        set(LLVM_LIT_TOOLS_DIR "" CACHE PATH "Path to GnuWin32 tools")
----------------
No space around the condition


================
Comment at: test/CMakeLists.txt:29
+endif()
+set(LLD_TEST_DEPS ${LLD_TEST_DEPS} lld)
+
----------------
I think that I would rather see this as:

    set(LLD_TEST_DEPS lld)
    if(NOT LLD_BUILT_STANDALONE)
      list(APPEND LLD_TEST_DEPS FileCheck not llvm-ar ...)
    endif()


https://reviews.llvm.org/D28750