Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Looks fine to me as long as we've resolved the semantic issues here. I'd wait for what Chandler &&/|| David have to say. https://reviews.llvm.org/D29314