[llvm] r293417 - Add some Book-E instructions to the asm parser and printer.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 17:28:37 PST 2017


On 01/30/2017 06:48 PM, Hans Wennborg wrote:

> On Sun, Jan 29, 2017 at 6:58 AM, Dimitry Andric <dimitry at andric.com> wrote:
>> On 29 Jan 2017, at 05:55, Justin Hibbits via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>> Author: jhibbits
>>> Date: Sat Jan 28 22:55:57 2017
>>> New Revision: 293417
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=293417&view=rev
>>> Log:
>>> Add some Book-E instructions to the asm parser and printer.
>>>
>>> Summary:
>>> Adds the following instructions:
>>> * mfpmr
>>> * mtpmr
>>> * icblc
>>> * icblq
>>> * icbtls
>>>
>>> Fix the scheduling for mtspr on e5500, which uses CFX0, instead of
>>> SFX0/SFX1 as on e500mc.
>>>
>>> Addresses PR 31538.
>> Let's pull this into FreeBSD's copy of clang now, but it would also be
>> nice to get this into 4.0.0, once it has baked for a while.  That is,
>> if Hal is OK with it.
> This looks like new functionality. I'm not sure it's appropriate for merging.
>
> Hal, can you comment on the risk/benefit here?

It is new functionality. It seems very low risk; the benefit seems to be 
that it enables compiling the FreeBSD kernel. I'm okay with taking it.

  -Hal


-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list