[PATCH] D28688: MC: Introduce the ABS8 symbol modifier.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/include/llvm/MC/MCExpr.h:193
     VK_WEAKREF,   // The link between the symbols in .weakref foo, bar
+    VK_ABS8,
 
----------------
RKSimon wrote:
> Should this be VK_X86_ABS8 or do we expect other targets to use this?
Browsing the lists of relocations in `include/llvm/Support/ELFRelocs` I can see that ARM and a few other targets have 8-bit relocations, but then of course ARM represents immediate operands in a completely different way (haven't thought about other targets).  Renamed to be X86-specific and we can think about a more generic name if a need arises.


https://reviews.llvm.org/D28688