[PATCH] D29283: [ARM] Avoid using ARM instructions in Thumb mode

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 07:53:47 PST 2017


samparker created this revision.
Herald added subscribers: rengolin, aemerson.

The Requires class overrides the target requirements of an instruction, rather than adding to them, so all ARM instructions need to include the IsARM predicate when they have overwitten requirements. This caused the swp and swpb instructions to be allowed in thumb mode assembly, and the ARM encoding of CDP to be selected in codegen (which is different for conditional instructions).


https://reviews.llvm.org/D29283

Files:
  lib/Target/ARM/ARMInstrInfo.td
  test/CodeGen/ARM/2009-05-18-InlineAsmMem.ll
  test/CodeGen/Thumb2/conditional-cdp.ll
  test/MC/ARM/thumb2-diagnostics.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29283.86286.patch
Type: text/x-patch
Size: 5958 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170130/c6dca36b/attachment.bin>


More information about the llvm-commits mailing list