[PATCH] D29276: [ELF] - Linkerscript: do not fail on additional semicolons in linkerscript.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 07:17:31 PST 2017


grimar added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1497
+    if (Tok == ";") {
+      // Commands may contain excessive additional semicolons around.
+      // We should be able to parse it.
----------------
jhenderson wrote:
> Slight grammar issue here - I think this should say something like "Commands may be surrounded by unnecessary additional semicolons", or better yet something like "Unnecessary semicolons are permitted here, but should be ignored."
Fixed, thanks.


https://reviews.llvm.org/D29276





More information about the llvm-commits mailing list