[PATCH] D28435: [compiler-rt] Define delimiters for sanitizer coverage's binary section on Windows.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added a comment.

Hi @alekseyshl @kcc,

Related to the changes explained in: https://reviews.llvm.org/D28434  `___[start|stop]___sancov_guard` should be defined only once per module.
In Windows, we have 2 different cases:

+ When considering MD:

  All the modules, main executable and dlls, are linked to an auxiliary static library "asan_dynamic_runtime_thunk.lib". Because of that, I include `sanitizer_coverage_win_sections.cc` to `SancovDynamicRuntimeThunk`.

+ When considering MT:

  The main executable in linked to the static library: "asan.lib".
  All the dlls are linked to an auxiliary static library "asan_dll_thunk.lib".
  Because of that, I include `sanitizer_coverage_win_sections.cc` to both `SancovDllThunk` and `SANITIZER_LIBCDEP_SOURCES` (which is included in `asan.lib`).

Would you agree?

@kcc all the reorganization required was included in these diffs: 
+ https://reviews.llvm.org/D29148
+ https://reviews.llvm.org/D29154
+ https://reviews.llvm.org/D29158


https://reviews.llvm.org/D28435