[PATCH] D29120: [ImplicitNullCheck] Extend canReorder scope

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 29 22:44:10 PST 2017


skatkov added a comment.

One more place should be fixed I guess.



================
Comment at: lib/CodeGen/ImplicitNullChecks.cpp:362
     // checked in \c IsSuitableMemoryOp.
     assert(!TRI->regsOverlap(DependenceMO.getReg(), PointerReg) &&
            "Should have been checked before!");
----------------
I think this should be fixed as well as check only for defs. Will try to write a test today.
  


https://reviews.llvm.org/D29120





More information about the llvm-commits mailing list