[PATCH] D29148: [compiler-rt] Provide a list of functions from sanitizers's interfaces.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 29 16:35:23 PST 2017


mpividori updated this revision to Diff 86236.
mpividori added a comment.

@kubamracek @kcc

I updated the diff to include tests for: Linux, Darwin and Windows. Now, if you export a new function not present in the interface list, the test "interface_symbols_[darwin|windows|linux].c" fails.

Also, I remove the comments: "/* OPTIONAL */" which are not required any more, because we use the macro: "INTERFACE_WEAK_FUNCTION()" for weak functions.

I tested on Linux, and Windows. Could you check if the test works on Darwin? Probably need to change some details.

Also, we could remove the "weak_symbols.txt" files and read the "interface.inc" files for Darwin.

Thanks.


https://reviews.llvm.org/D29148

Files:
  lib/asan/asan_interface.inc
  lib/asan/asan_interface_internal.h
  lib/sanitizer_common/sanitizer_allocator_interface.h
  lib/sanitizer_common/sanitizer_common_interface.inc
  lib/sanitizer_common/sanitizer_common_interface_posix.inc
  lib/sanitizer_common/sanitizer_coverage_interface.inc
  lib/ubsan/ubsan_interface.inc
  test/asan/TestCases/Darwin/interface_symbols_darwin.c
  test/asan/TestCases/Linux/interface_symbols_linux.c
  test/asan/TestCases/Windows/interface_symbols_windows.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29148.86236.patch
Type: text/x-patch
Size: 29195 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170130/8f07605b/attachment-0001.bin>


More information about the llvm-commits mailing list