[PATCH] D29261: [X86][GlobalISel] Add limited ret lowering support to the IRTranslator.

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: lib/Target/X86/X86CallLowering.cpp:44
+
+  const X86TargetLowering &TLI = *getTLI<X86TargetLowering>();
+  LLVMContext &Context = OrigArg.Ty->getContext();
----------------
Isn't there already a class member that can be casted to X86TargetLowering?


================
Comment at: lib/Target/X86/X86CallLowering.cpp:125
+
+  MIRBuilder.insertInstr(MIB);
+  return Success;
----------------
Is it ok to insert if Success == false?


================
Comment at: lib/Target/X86/X86CallLowering.cpp:195
+  MachineBasicBlock &MBB = MIRBuilder.getMBB();
+  if (!MBB.empty())
+     MIRBuilder.setInstr(*MBB.begin());
----------------
Is there a test-case for when the condition is false?


================
Comment at: lib/Target/X86/X86CallLowering.h:38
+private:
+  typedef std::function<void(ArrayRef<unsigned>, ArrayRef<uint64_t>)>
+      SplitArgTy;
----------------
Can you please document this typedef? What is it used for and what are the roles of the arguments?


Repository:
  rL LLVM

https://reviews.llvm.org/D29261