[PATCH] D29201: [X86][Disassembler] Added SALC instruction

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 28 16:21:10 PST 2017


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrCMovSetCC.td:113
 
+let Uses = [EFLAGS], Defs = [AL] in {
+  def SALC : I<0xD6, RawFrm, (outs), (ins), "salc", []>;
----------------
I think we need a Requires<[Not64BitMode]> here. sandpile.org and http://www.agner.org/optimize/instruction_tables.pdf both indicate its not available in 64-bit mode.

Can you also add a comment that's it undocumented just so its obvious why you can't find it in Intel or AMD official docs.


https://reviews.llvm.org/D29201





More information about the llvm-commits mailing list