[PATCH] D29203: Change debug-info-for-profiling from a TargetOption to a function attribute.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Commented on bitcode test



================
Comment at: test/Bitcode/upgrade-debug-info-for-profiling.ll:4
+
+define void @foo() {
+  ret void
----------------
This probably isn't necessary.


================
Comment at: test/Bitcode/upgrade-debug-info-for-profiling.ll:13
+; CHECK: DICompileUnit{{.*}} debugInfoForProfiling: true
+!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, emissionKind: FullDebug, debugInfoForProfiling: true)
+!2 = !DIFile(filename: "foo.c", directory: "/path/to/dir")
----------------
Perhaps I'm confused about what this is testing*, but shouldn't the default be debugInfoForProfiling: false?

*) I was expecting a DICompilieUnit produced by today's trunk without a bitcode record for the new flag, so we can verify that the old bitcode format is updated correctly.


https://reviews.llvm.org/D29203