[PATCH] D28336: Replace addEarlyAsPossiblePasses callback with adjustPassManager

[Will Dietz via Phabricator via llvm-commits]

dtzWill added a comment.

In https://reviews.llvm.org/D28336#658899, @rampitec wrote:

> In https://reviews.llvm.org/D28336#658696, @dtzWill wrote:
>
> > Looks like this was fixed for NVPTX in  r293256, Hexagon earlier.  Can confirm resolves the issue I was encountering, thanks!
> >
> > (And I think you're right, it only seems to have occurred in the shared library variants)
> >
> > But now undefined reference in AMDGPU haha, but not relating to PassManagerBuilder :).
>
>
> Thanks and sorry I did not notice it right away. For some reason my builds do work, just as Linux shared build I did right now. Do you still see error building AMDGPU or is it already fixed as well?


No worries :).  Recently GlobalISel started to defaulting to 'on' which exposes the (conditionally) missing dependency... I committed a fix in r293387.

re:that change, I didn't see any way to make LLVMBuild.txt contain conditional dependencies so it might overlink when GlobalISel is disabled? But it's what the other targets do so hopefully that's not a problem.

As for why you didn't see it, honestly my build env is sufficiently strange that I'd be happy to blame it on that-- among other things I'm intentionally forcing stricter linking behavior which would the different results.

Also, if you explicitly disable GlobalISel or maybe if an update+rebuild retained the previous default value of "off"? Dunno :).

Anyway, should be fixed now, thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D28336