[PATCH] D29214: [AMDGPU] Internalize non-kernel symbols

[Tony Tye via Phabricator via llvm-commits]

tony-tye added inline comments.


================
Comment at: test/CodeGen/AMDGPU/internalize.ll:7-8
+
+ at gvar_unused = addrspace(1) global i32 undef, align 4
+ at gvar_used = addrspace(1) global i32 undef, align 4
+
----------------
rampitec wrote:
> arsenm wrote:
> > Should this check with various linkage types that should remain visible?
> As long as there is no late linking there are no linkages which should remain visible. Do you have an example?
The HSA Runtime can be used to query the address of global symbols so that the host program can access them. Will that still work after this phase?


Repository:
  rL LLVM

https://reviews.llvm.org/D29214