[llvm] r292188 - [TLI] Add prototype checking for all remaining LibFuncs.

[Ahmed Bougacha via llvm-commits]

Hey folks,

I'm pondering whether to merge this to 4.0.  It's not a small change,
but it's hopefully only making existing functionality stricter.

It fixes a handful of issues, some introduced by r267758 (in 3.9),
some of which can be exposed in C code (using invalid libc protos; I
could probably reduce the patch to the funcs I know of?).

Does that sound desirable? Thanks!

-Ahmed

On Mon, Jan 16, 2017 at 7:10 PM, Ahmed Bougacha via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: ab
> Date: Mon Jan 16 21:10:02 2017
> New Revision: 292188
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292188&view=rev
> Log:
> [TLI] Add prototype checking for all remaining LibFuncs.
>
> This is another step towards unifying all LibFunc prototype checks.
> This work started in r267758 (D19469);  add the remaining checks.
>
> Also add a unittest that checks each libfunc declared with a known-valid
> and known-invalid prototype.  New libfuncs added in the future are
> required to have prototype checking in place; the known-valid test will
> fail otherwise.
>
> Differential Revision: https://reviews.llvm.org/D28030
>
> Added:
>     llvm/trunk/unittests/Analysis/TargetLibraryInfoTest.cpp
> Modified:
>     llvm/trunk/lib/Analysis/TargetLibraryInfo.cpp
>     llvm/trunk/unittests/Analysis/CMakeLists.txt