[PATCH] D28596: [compiler-rt] General definition for weak functions.

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 18:54:38 PST 2017


alekseyshl added a comment.

LGTM



================
Comment at: lib/asan/asan_win_dll_thunk.cc:337
+//INTERFACE_FUNCTION(__sanitizer_cov_trace_pc_guard)
+//INTERFACE_FUNCTION(__sanitizer_cov_trace_pc_guard_init)
 INTERFACE_FUNCTION(__sanitizer_cov_with_check)
----------------
If you don't need those two functions, just delete them.


https://reviews.llvm.org/D28596





More information about the llvm-commits mailing list